Add import conditions to prevent node dependencies in client bundle #3832
+46
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jog1t
commented
Jan 11, 2026
jog1t
commented
- Add import conditions to package.json exports to prevent node-only dependencies from being bundled in browser environments
- Move get-port to optionalDependencies since it's only needed for Node.js server environments
- Add error handling in serve.ts for missing get-port dependency
- Browser environments will automatically get the client-only build when importing from 'rivetkit'
- Node.js environments get the full server build with Registry and server utilities
- Add import conditions to package.json exports to prevent node-only dependencies from being bundled in browser environments - Move get-port to optionalDependencies since it's only needed for Node.js server environments - Add error handling in serve.ts for missing get-port dependency - Browser environments will automatically get the client-only build when importing from 'rivetkit' - Node.js environments get the full server build with Registry and server utilities
|
🚅 Deployed to the rivet-pr-3832 environment in rivet-frontend
|
Contributor
Graphite Automations"Test" took an action on this PR • (01/11/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.