fix(meta): fix & enable e2e tests with MySQL meta backend #19846
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
github-actions
bot
added
type/fix
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
fuyufjh
approved these changes
Dec 19, 2024
| @@ -0,0 +1,4 @@ | |||
| disallowed-methods = [ | |||
| { path = "sea_query::table::column::ColumnDef::binary", reason = "Please use `.rw_binary(..)` instead." }, | |||
There was a problem hiding this comment.
Can you explain it by some comments?
There was a problem hiding this comment.
Yes, it's explained in docs:
/// Set column type as `longblob` for MySQL, `bytea` for Postgres, and `blob` for Sqlite.
///
/// Should be preferred over [`binary`](ColumnDef::binary) or [`blob`](ColumnDef::blob) for large binary fields,
/// typically the fields wrapping protobuf or other serialized data. Otherwise, MySQL will return an error
/// when the length exceeds 65535 bytes.
Signed-off-by: Bugen Zhao <[email protected]>
stdrc
reviewed
Dec 20, 2024
Comment on lines
-13
to
+19
| .add_column(ColumnDef::new(Connection::Params).binary().not_null()) | ||
| .add_column( | ||
| ColumnDef::new(Connection::Params) | ||
| .rw_binary(manager) | ||
| .not_null(), | ||
| ) |
There was a problem hiding this comment.
Is it correct to directly change an existing migration script? Not sure, just want to confirm.
There was a problem hiding this comment.
Only for MySQL, I think it's okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow up of #19595. Address bugs for MySQL meta backend and re-enable it.
Checklist
Documentation
Release note