Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): remove chunk splitting logic in apply_rate_limit #19826

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After #19698, we can expect chunks yielded to SourceExecutors to be smaller than SourceCtrlOpts::chunk_size, so we don't need to split chunks in apply_rate_limit (used by FetchExecutor, FsSourceExecutor, SourceBackfillExecutor and SourceExecutor) anymore.

This PR removes the chunk splitting logic from apply_rate_limit.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@stdrc stdrc changed the title remove chunk splitting logic in apply_rate_limit refactor(source): remove chunk splitting logic in apply_rate_limit Dec 17, 2024
@stdrc stdrc marked this pull request as ready for review December 17, 2024 08:16
@stdrc stdrc force-pushed the rc/respect-chunk-size-limit branch from 9fc46c4 to 10e0ea4 Compare December 18, 2024 02:48
@stdrc stdrc requested a review from a team as a code owner December 18, 2024 02:48
@stdrc stdrc force-pushed the rc/simplify-apply-rate-limit branch 2 times, most recently from 1911360 to 489ce16 Compare December 18, 2024 05:33
@stdrc stdrc force-pushed the rc/respect-chunk-size-limit branch from eeeebb4 to 486f99c Compare December 18, 2024 06:08
@stdrc stdrc force-pushed the rc/simplify-apply-rate-limit branch 3 times, most recently from ab4d67f to 2ad77a8 Compare December 18, 2024 09:23
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/respect-chunk-size-limit branch from d986091 to b1a892c Compare December 19, 2024 05:34
@stdrc stdrc force-pushed the rc/simplify-apply-rate-limit branch from 2ad77a8 to 1069774 Compare December 19, 2024 05:35
@stdrc stdrc force-pushed the rc/simplify-apply-rate-limit branch from 1069774 to 3f15274 Compare December 19, 2024 05:37
@stdrc stdrc changed the base branch from rc/respect-chunk-size-limit to rc/connector-parser-renaming December 19, 2024 05:37
@stdrc stdrc force-pushed the rc/simplify-apply-rate-limit branch from 3f15274 to bd6796d Compare December 19, 2024 05:40
@stdrc stdrc changed the base branch from rc/connector-parser-renaming to rc/respect-chunk-size-limit December 19, 2024 05:40
Base automatically changed from rc/respect-chunk-size-limit to main December 19, 2024 07:13
@graphite-app graphite-app bot requested a review from a team December 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant