-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(source): remove chunk splitting logic in apply_rate_limit
#19826
Open
stdrc
wants to merge
15
commits into
main
Choose a base branch
from
rc/simplify-apply-rate-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+436
−331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This was referenced Dec 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
changed the title
remove chunk splitting logic in
refactor(source): remove chunk splitting logic in Dec 17, 2024
apply_rate_limit
apply_rate_limit
stdrc
requested review from
chenzl25,
tabVersion,
xxchan,
kwannoel and
zwang28
December 17, 2024 08:16
stdrc
force-pushed
the
rc/respect-chunk-size-limit
branch
from
December 18, 2024 02:48
9fc46c4
to
10e0ea4
Compare
stdrc
force-pushed
the
rc/simplify-apply-rate-limit
branch
2 times, most recently
from
December 18, 2024 05:33
1911360
to
489ce16
Compare
stdrc
force-pushed
the
rc/respect-chunk-size-limit
branch
from
December 18, 2024 06:08
eeeebb4
to
486f99c
Compare
stdrc
force-pushed
the
rc/simplify-apply-rate-limit
branch
3 times, most recently
from
December 18, 2024 09:23
ab4d67f
to
2ad77a8
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
…iter Signed-off-by: Richard Chien <[email protected]>
… type Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/respect-chunk-size-limit
branch
from
December 19, 2024 05:34
d986091
to
b1a892c
Compare
stdrc
force-pushed
the
rc/simplify-apply-rate-limit
branch
from
December 19, 2024 05:35
2ad77a8
to
1069774
Compare
8 tasks
stdrc
force-pushed
the
rc/simplify-apply-rate-limit
branch
from
December 19, 2024 05:37
1069774
to
3f15274
Compare
stdrc
changed the base branch from
rc/respect-chunk-size-limit
to
rc/connector-parser-renaming
December 19, 2024 05:37
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/simplify-apply-rate-limit
branch
from
December 19, 2024 05:40
3f15274
to
bd6796d
Compare
stdrc
changed the base branch from
rc/connector-parser-renaming
to
rc/respect-chunk-size-limit
December 19, 2024 05:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After #19698, we can expect chunks yielded to
SourceExecutor
s to be smaller thanSourceCtrlOpts::chunk_size
, so we don't need to split chunks inapply_rate_limit
(used byFetchExecutor
,FsSourceExecutor
,SourceBackfillExecutor
andSourceExecutor
) anymore.This PR removes the chunk splitting logic from
apply_rate_limit
.Checklist
Documentation
Release note