feat(frontend): Supports cut OR condition and push down to storage #19812
+817
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/batch_predicate_pushdown
Li0k
changed the title
…nto li0k/batch_predicate_pushdown
Li0k
changed the title
Li0k
changed the title
st1page
reviewed
Dec 18, 2024
| @@ -418,7 +418,7 @@ | |||
| batch_plan: |- | |||
| BatchExchange { order: [], dist: Single } | |||
| └─BatchFilter { predicate: (((orders_count_by_user.user_id = 1:Int32) OR ((orders_count_by_user.user_id = 2:Int32) AND In(orders_count_by_user.date, 1111:Int32, 2222:Int32))) OR (orders_count_by_user.user_id <> 3:Int32)) } | |||
| └─BatchScan { table: orders_count_by_user, columns: [orders_count_by_user.user_id, orders_count_by_user.date, orders_count_by_user.orders_count], distribution: UpstreamHashShard(orders_count_by_user.user_id, orders_count_by_user.date) } | |||
| └─BatchScan { table: orders_count_by_user, columns: [orders_count_by_user.user_id, orders_count_by_user.date, orders_count_by_user.orders_count], scan_ranges: [orders_count_by_user.user_id = Int64(1), orders_count_by_user.user_id = Int64(2) AND orders_count_by_user.date = Int32(1111), orders_count_by_user.user_id = Int64(2) AND orders_count_by_user.date = Int32(2222)], distribution: UpstreamHashShard(orders_count_by_user.user_id, orders_count_by_user.date) } | |||
There was a problem hiding this comment.
I think this can not be pushed down with condition orders_count_by_user.user_id <> 3:Int32?
There was a problem hiding this comment.
Good catch, I didn't realize that full table scan range would be converted to empty vec, and I fixed it with a special judgment.
|
Test: CREATE TABLE t1(v1 int primary key);
INSERT INTO t1 (v1) SELECT v FROM generate_series(1, 10000000) AS v;
SELECT COUTN(*) FROM t1;
SELECT * FROM t1 WHERE (v1 > 10 AND v1 < 20) OR (v1 > 5000000 AND v1 < 5000100);before: after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related to #19525
This PR implements the optimizations mentioned in the issue
Checklist
Documentation
Release note