Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): warn when fragment mapping not found #19105

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Batch should not panic even metadata is inconsistent somehow.

#19091

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 8cf092f Oct 24, 2024
38 of 39 checks passed
@kwannoel kwannoel deleted the wangzheng/fix_panic branch October 24, 2024 09:26
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
@BugenZhao
Copy link
Member

I think this is somehow an assertion. May I ask whether we know the reason why it can be inconsistent?

@kwannoel
Copy link
Contributor

I think this is somehow an assertion. May I ask whether we know the reason why it can be inconsistent?

I think @zwang28 is still investigating. @zwang28 could you open an issue to track it with more details? Thanks

@zwang28
Copy link
Contributor Author

zwang28 commented Nov 5, 2024

I think this is somehow an assertion. May I ask whether we know the reason why it can be inconsistent?

I think @zwang28 is still investigating. @zwang28 could you open an issue to track it with more details? Thanks

#19091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants