Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): default new compaction group for new table #19080

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Oct 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

after #18806

Since we introduced an automatic compaction group merge policy for hummock. Therefore, we can extend this by placing newly created tables into separate compaction groups for greater isolation.

  1. The newly created table is isolated from the existing table.
  2. after creation, the automated policy is re-scheduled based on the state of the group table.
  3. when table creation fails, the data can be reclaimed by trivial-recliam, not coupled with the existing data.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Li0k
Copy link
Contributor Author

Li0k commented Oct 25, 2024

@Li0k
Copy link
Contributor Author

Li0k commented Oct 30, 2024

@Li0k Li0k requested review from hzxa21 and zwang28 November 4, 2024 05:14
@Li0k Li0k marked this pull request as ready for review November 4, 2024 05:15
@Li0k Li0k enabled auto-merge November 5, 2024 09:30
Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 9a32e75 Nov 6, 2024
31 of 32 checks passed
@Li0k Li0k deleted the li0k/compaction_new_table_cg branch November 6, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants