Skip to content

Commit

Permalink
add comments
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <[email protected]>
  • Loading branch information
BugenZhao committed Oct 27, 2023
1 parent b80d6db commit f667892
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/connector/src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,8 @@ impl SourceStreamChunkRowWriter<'_> {
Err(error) => {
// TODO: figure out a way to fill in not-null default value if user specifies one
// TODO: decide whether the error should not be ignored (e.g., even not a valid Debezium message)
// TODO: not using tracing span to provide `split_id` and `offset` due to performance concern,
// see #13105
tracing::warn!(
%error,
split_id = self.row_meta.as_ref().map(|m| m.split_id),
Expand Down Expand Up @@ -569,6 +571,8 @@ async fn into_chunk_stream<P: ByteStreamSourceParser>(mut parser: P, data_stream
}

if let Err(error) = res {
// TODO: not using tracing span to provide `split_id` and `offset` due to performance concern,
// see #13105
tracing::error!(
%error,
split_id = &*msg.split_id,
Expand Down

0 comments on commit f667892

Please sign in to comment.