Refactor the control_check_pc API. #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadime15
approved these changes
Aug 22, 2025
This makes it return just an option instead of also a possibly modified target address. The more general API was once used for an earlier CHERI model, but now the generality is not used.
pmundkur
force-pushed
the
refactor_control_check_pc
branch
from
3a308fb to
529f45c
Compare
Timmmm
approved these changes
Sep 5, 2025
pmundkur
added
the
will be merged
jordancarlin
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it return just an optional exception instead of also a possibly modified target address.
The more general API was once used for an earlier CHERI model, but now the generality is not used.
Addresses #1205.