-
Notifications
You must be signed in to change notification settings - Fork 228
Refactor vector extension configuration. #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wwwwwwOwO
wants to merge
15
commits into
riscv:master
Choose a base branch
from
wwwwwwOwO:feat/vector-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+355
−116
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0409e6b
Refactor vector extension configuration.
wwwwwwOwO fd3e5b9
Fix currentlyEnabled(Ext_Zvfhmin) and add Zve*, Zvfh* to README.
wwwwwwOwO 866135b
Fix currentlyEnabled(Ext_Zvfhmin) and add Zve*, Zvfh* to README.
wwwwwwOwO 40b9588
Refactor currentlyEnabled_measure() for vector extensions.
wwwwwwOwO 253c852
Refactor configuration for vector bit manipulation and cryptography e…
wwwwwwOwO eb4d5a4
Fix termination value for Zvfhmin.
wwwwwwOwO ad0d473
Remove unnecessary whitespaces.
wwwwwwOwO 122741a
Fix currentlyEnabled() for Zvkb.
wwwwwwOwO f06cbb6
Remove file deleted on master
wwwwwwOwO e38a08a
Merge branch 'master' into feat/vector-config
wwwwwwOwO 4ec70a0
Merge branch 'riscv:master' into feat/vector-config
wwwwwwOwO 9813d63
Merge branch 'riscv:master' into feat/vector-config
wwwwwwOwO e9b7d80
Implement elen/Zve* handling: retain ELEN in config, add V.{F,D} flags.
pmundkur 96d0e22
Add "V.x.supported" flag and restore "V.supported".
pmundkur 76aef9a
Update readme and changelog.
pmundkur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this version is arguably more confusing now. Having a key called
supported
would indicate to me that everything within theV
key is gated by that, not that it just enables a few extra instructions that only come with the full V extension. What about having all of this within avector_configuration
key (or something along those lines)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually like the x_supported, what about: