Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata styling for Multi Purpose Token #1057

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

pdp2121
Copy link
Collaborator

@pdp2121 pdp2121 commented Oct 10, 2024

High Level Overview of Change

MPTokenMetadata is an essential part of a MPT token as it allows issuers to define their own metadata standards, tailored to their specific requirements, encompassing details like asset codes, common names, symbols, or even visual representations.

This PR formats the display of this metadata field in the Explorer by adding json formatter for readability.

Context of Change

Spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

Before / After

MPTokenIssuanceCreate Page:

Screenshot 2024-10-10 at 3 53 01 PM

MPT Page:
Screenshot 2024-10-10 at 3 53 20 PM

@mvadari
Copy link
Collaborator

mvadari commented Oct 10, 2024

Why not use SimpleGroup instead?

image

Or how the hook parameters are done here:
image

Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdp2121
Copy link
Collaborator Author

pdp2121 commented Oct 14, 2024

Why not use SimpleGroup instead?

image

Or how the hook parameters are done here: image

I was thinking of this at first but since we don't have a standardized structure for metadata, the SimpleGroup might get messy (when there's nested json or array for example). Julian and I both think we can just use the Json formatter for now and revisit once the metadata structure has been defined, probably in the next couple of months. Please let me know if you think differently.

@mvadari
Copy link
Collaborator

mvadari commented Oct 14, 2024

I was thinking of this at first but since we don't have a standardized structure for metadata, the SimpleGroup might get messy (when there's nested json or array for example). Julian and I both think we can just use the Json formatter for now and revisit once the metadata structure has been defined, probably in the next couple of months. Please let me know if you think differently.

That's fair - if you don't know how much it'll be nested that can get complex. Makes sense for now.

@pdp2121 pdp2121 merged commit 6d1d9d1 into staging Oct 14, 2024
4 checks passed
@pdp2121 pdp2121 deleted the mpt-metadata-styling branch October 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants