Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon URL to correct path #1055

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Change icon URL to correct path #1055

merged 4 commits into from
Oct 15, 2024

Conversation

achowdhry-ripple
Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple commented Oct 8, 2024

High Level Overview of Change

Google chrome search result icon was broken, edited links to point to correct assets.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@achowdhry-ripple achowdhry-ripple marked this pull request as draft October 8, 2024 15:53
@achowdhry-ripple achowdhry-ripple self-assigned this Oct 8, 2024
@achowdhry-ripple achowdhry-ripple marked this pull request as ready for review October 15, 2024 14:47
@pdp2121 pdp2121 merged commit 3df3fb4 into staging Oct 15, 2024
4 checks passed
@pdp2121 pdp2121 deleted the search-engine-icon branch October 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants