fix: link to AMM account page from transactions (#832)

At some point the property `AMMAccount` on `AMM` ledger entries was changed to `Account`. I also opened a PR on the documentation site. ripple/opensource.ripple.com#63 Fixes #734
ripple · Sep 25, 2023 · eb1dcb3 · eb1dcb3
1 parent 58d3b66
commit eb1dcb3
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 14 deletions.
diff --git a/src/containers/shared/components/Transaction/AMMBid/test/mock_data/amm_bid.json b/src/containers/shared/components/Transaction/AMMBid/test/mock_data/amm_bid.json
@@ -58,7 +58,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMCreate/test/mock_data/amm_create.json b/src/containers/shared/components/Transaction/AMMCreate/test/mock_data/amm_create.json
@@ -160,7 +160,7 @@
           "LedgerEntryType": "AMM",
           "LedgerIndex": "C7FD06649235AF4CABD8FA6D8BB0CAF6C6EA5038A74D0DDD5025290683636D02",
           "NewFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset2": {
               "currency": "USD",
               "issuer": "rhpHaFggC92ELty3n3yDEtuFgWxXWkUFET"

diff --git a/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_both.json b/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_both.json
@@ -146,7 +146,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_eprice.json b/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_eprice.json
@@ -87,7 +87,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
+            "Account": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_nonxrp.json b/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_nonxrp.json
@@ -69,7 +69,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rEJ1X5BoSmHqa5h6TSVvYrHAzFmyxGqNic",
+            "Account": "rEJ1X5BoSmHqa5h6TSVvYrHAzFmyxGqNic",
             "Asset": {
               "currency": "EUR",
               "issuer": "rEaiyQKvxYWmh7q9mvSm11kZmKx92HZdmr"

diff --git a/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_usd.json b/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_usd.json
@@ -150,7 +150,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_xrp.json b/src/containers/shared/components/Transaction/AMMDeposit/test/mock_data/deposit_xrp.json
@@ -76,7 +76,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMVote/test/mock_data/amm_vote.json b/src/containers/shared/components/Transaction/AMMVote/test/mock_data/amm_vote.json
@@ -23,7 +23,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw.json b/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw.json
@@ -169,7 +169,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
+            "Account": "rMEdVzU8mtEArzjrN9avm3kA675GX7ez8W",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_eprice.json b/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_eprice.json
@@ -138,7 +138,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
+            "Account": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_usd.json b/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_usd.json
@@ -82,7 +82,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
+            "Account": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_xrp.json b/src/containers/shared/components/Transaction/AMMWithdraw/test/mock_data/withdraw_xrp.json
@@ -61,7 +61,7 @@
       {
         "ModifiedNode": {
           "FinalFields": {
-            "AMMAccount": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
+            "Account": "rHrzrzVHSyunKzW3JLgSaLcsxfwVLPVV97",
             "Asset": {
               "currency": "XRP"
             },

diff --git a/src/containers/shared/metaParser.tsx b/src/containers/shared/metaParser.tsx
@@ -19,8 +19,7 @@ Gets the AMM account ID
 export function getAMMAccountID(meta: any) {
   const account = findNodes(meta, LedgerEntryTypes.AMM)[0]
 
-  if (account)
-    return account.FinalFields?.AMMAccount || account.NewFields?.AMMAccount
+  if (account) return account.FinalFields?.Account || account.NewFields?.Account
 
   return undefined
 }