Skip to content

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Jan 7, 2026

requested: #8450

loom.com/share/a69eb3af381a44bbb9ba028c9f3a6b3a?from_recorder=1&focus_title=1

Some changes:

  • no longer underlines the tab, it looked too crowded with the carrot, dropdown
  • less tall div in navbar for each icon (caused the jittery movement when hovering from icon to dropdown)
  • reset on the navbar css, had Claude rewrite it.
  • kind of like the default algolia search ui better, but made it wider than default

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo royendo requested a review from ericpgreen2 January 7, 2026 17:30
@royendo
Copy link
Contributor Author

royendo commented Jan 7, 2026

Can you move the "Reference" tab changes into its own dedicated PR? This PR is huge and we'll need to polish the aesthetics of the dropdown before merge. For example:

The dropdown is jumping when I try to hover over the menu items
Hovering a menu item should apply a background color
The dropdown arrow looks a bit heavy and misaligned
The dropdown menu should be left-aligned with its anchor element

@royendo
Copy link
Contributor Author

royendo commented Jan 7, 2026

can take another look if we want to bring back the "taller" text padding but not sure if really needed.. 🤔

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Summary

Good progress consolidating Reference content into a dropdown. A few content and design items to address before this is ready.


Content & IA

1. docs/docusaurus.config.js (dropdown items)

Missing items and label change:

  • Add "Time Syntax" (/reference/rill-iso-extensions) to the dropdown—it's reference content that's currently missing
  • Rename "API" to "REST API" for clarity

Design

2. docs/src/css/_navbar.scss (active state styling)

Layout shift issue: The current font-weight: 600 for active items causes adjacent nav items to shift when clicking between them. Options:

Option Implementation Trade-off
Underline only Remove bold, keep ::after underline No shift, but you mentioned underline + caret felt noisy
Color only Remove bold entirely, rely on color Minimal, but may feel too subtle
Fixed width Set explicit width on nav items Prevents shift, but may look awkward
Pseudo-element trick Add invisible bold text via ::before to reserve space Preserves current look, no shift

3. docs/src/css/_navbar.scss (navbar and dropdown styling)

Design polish:

  • Top nav padding: The top navbar items have inconsistent padding/widths on hover. Audit and standardize.
  • Dropdown gap: Add margin-top: 4px to .dropdown__menu for breathing room between trigger and popover.
  • Dropdown size: Menu items feel oversized. Consider tightening padding from 0.5rem 0.75rem to 0.375rem 0.75rem.
  • Caret: The default Docusaurus down-arrow looks dated. Consider replacing with a Rill-style chevron.

Code Cleanup

4. docs/src/theme/Navbar/index.js (lines 54-101)

Two MutationObservers: Both useEffect hooks watch document.body with identical options. Consider consolidating into a single observer.

5. docs/src/css/_navbar.scss (various)

Minor cleanup:

  • Lines 17-19: Duplicate comment ("Active navbar item" / "Active navbar link"). Remove the first.
  • Line 107: Use 0.5px instead of .5px for consistency. Consider a CSS variable for the hardcoded #e5e7eb.
  • Lines 227-230: Dead selector .mobile-nav-icon-links—the JS was removed, so this targets nothing.

Developed in collaboration with Claude Code

@royendo
Copy link
Contributor Author

royendo commented Jan 7, 2026

  1. docs/docusaurus.config.js (dropdown items)
    This one is moving to build/ in docs: separating developer and user docs #8450 but theres a few link stuff that is already fixed there so will leave it alone on this branch

2-5
Screenshot 2026-01-07 at 15 46 42
Screenshot 2026-01-07 at 15 46 45

@royendo royendo requested a review from ericpgreen2 January 7, 2026 20:47
@royendo
Copy link
Contributor Author

royendo commented Jan 7, 2026

I think thats everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants