Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Re-ingest local files on updates #5656

Merged
merged 18 commits into from
Oct 16, 2024
Merged

feat: Re-ingest local files on updates #5656

merged 18 commits into from
Oct 16, 2024
+291 −11

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Sep 10, 2024 •
edited
Loading

closes #5479

Sample model file:

connector: local_file
path: "data/a.csv"

output:
  connector: duckdb
  materialize: true

Some considerations

  1. Only works if local file is stored in the repo directory.
  2. An input property invalidate_on_change: false can also be set to disable automatic updates. By default set to true.

@k-anshul k-anshul self-assigned this Sep 10, 2024
@k-anshul k-anshul changed the title feat: Re-ingest local files if they are updated on model reconcile feat: Re-ingest local files on updates Sep 17, 2024
begelundmuller
begelundmuller requested changes Sep 20, 2024
View reviewed changes
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/reconcilers/project_parser.go Outdated Show resolved Hide resolved
runtime/reconcilers/project_parser.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parser.go Outdated Show resolved Hide resolved
runtime/drivers/duckdb/model_executor_localfile_self.go Outdated Show resolved Hide resolved
runtime/drivers/duckdb/model_manager.go Outdated Show resolved Hide resolved
runtime/reconcilers/project_parser.go Outdated Show resolved Hide resolved
begelundmuller
begelundmuller requested changes Oct 4, 2024
View reviewed changes
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parser.go Outdated Show resolved Hide resolved
begelundmuller
begelundmuller requested changes Oct 15, 2024
View reviewed changes
runtime/compilers/rillv1/parse_model.go Outdated Show resolved Hide resolved
runtime/compilers/rillv1/parser.go Show resolved Hide resolved
begelundmuller
begelundmuller approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begelundmuller begelundmuller merged commit 59bf400 into main Oct 16, 2024
7 checks passed
@begelundmuller begelundmuller deleted the local_duckdb_me branch October 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime: Re-ingest local files if they are updated
2 participants
@k-anshul @begelundmuller