Compress flag images to reduce size of apps that use this package #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinerIsmail
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag images in this package are included in all the apps that use it. I found that by inspecting the apk through Android studio. I've also noticed that most of them are unoptimised, so I was able to reduce their size by using TinyPNG. This change will make every app that depends on this package smaller by almost 1MB, without any reduction in the quality of the images.
I have not changed the actual size (width/height) of any of the images, and there should be no noticeable difference in what they look like.
Total size reduction: 921,732 bytes (approximately 920 KB)
Number of files compressed: 178 flag images (some were already compressed)