Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement digippres.org changes and min sig length #253

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Implement digippres.org changes and min sig length #253

merged 3 commits into from
Jul 15, 2024

Commits on Jul 13, 2024

  1. Replace deprecated io.writefile with os.writefile

    @ross-spencer
    ross-spencer committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    6534ffb View commit details
    Browse the repository at this point in the history

  2. Update SPARQL query to be more performant 

    A filter is introduced to return more relevant results, rather than
nearly everything on Wikidata. The query also introduces file format
family signatures which can be handled equally by Siegfried and fills
some gaps in identification.

Co-authored-by: Andrew Jackson <[email protected]>
    @ross-spencer @anjackson
    ross-spencer and anjackson committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    22cb63e View commit details
    Browse the repository at this point in the history

  3. Implement Wikidata min signature length 

    This reduces the query time further and tackles some of the issues
in: ffdev-info/wikidp-issues#32

The signature length can be configured but the default while we
calibrate is '6', i.e. 3 bytes.
    @ross-spencer
    ross-spencer committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    76e1933 View commit details
    Browse the repository at this point in the history