Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an archive selector to Siegfried #141

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Conversation

ross-spencer
Copy link
Collaborator

Using the -zs flag will aloow users to specify which archive types
Siegfried cracks open to identify the contents of.

Loosely connected to #83

@ross-spencer ross-spencer force-pushed the dev/add-zip-selector branch 2 times, most recently from 61dc8b7 to 8bce6b7 Compare August 31, 2020 01:00
@ross-spencer
Copy link
Collaborator Author

Hi Richard. I had a look at this one today just in case it's in scope for 1.9. I've added a handful of in-line comments and a license header to the tests. It's looking pretty good for CR if so.

@ross-spencer ross-spencer self-assigned this Aug 31, 2020
@ross-spencer ross-spencer marked this pull request as draft September 14, 2020 17:49
@ross-spencer ross-spencer force-pushed the dev/add-zip-selector branch 2 times, most recently from 7fecdc8 to 35e8c5f Compare September 21, 2020 23:38
Using the -zs flag will aloow users to specify which archive types
Siegfried cracks open to identify the contents of.
@ross-spencer ross-spencer marked this pull request as ready for review September 21, 2020 23:54
@ross-spencer
Copy link
Collaborator Author

Hi @richardlehane this should be good to go! 🤞

Copy link
Owner

@richardlehane richardlehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks :)

@richardlehane richardlehane merged commit 18a1ed0 into develop Sep 22, 2020
@ross-spencer ross-spencer deleted the dev/add-zip-selector branch September 23, 2020 03:17
richardlehane added a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants