Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added descriptions and info to some of the missing parameters in the configuration table of the docs #167

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

jwreep
Copy link
Member

@jwreep jwreep commented Dec 11, 2023

Partially fixes #74

Added info for the configuration parameters I'm sure I understand.

Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwreep! Let me know if you agree with these minor changes and I'll go ahead and merge.

docs/config_tables.yml Outdated Show resolved Hide resolved
docs/config_tables.yml Outdated Show resolved Hide resolved
docs/config_tables.yml Outdated Show resolved Hide resolved
@jwreep
Copy link
Member Author

jwreep commented Jan 3, 2024

No arguments! Also, this shouldn't close #74 since it doesn't address all of the missing descriptions. There are a few variables I'm not confident in, so left them blank still.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8b615f) 69.28% compared to head (2599979) 69.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   69.28%   69.28%           
=======================================
  Files          11       11           
  Lines         713      713           
=======================================
  Hits          494      494           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes merged commit 3ed98ff into rice-solar-physics:main Jan 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill in missing parameter descriptions
2 participants