Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge behaviours of configs #68

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Fix merge behaviours of configs #68

merged 5 commits into from
Nov 9, 2023

Conversation

ribose-jeffreylau
Copy link
Contributor

Fixes #67 , but needs further clarification on desired dot position style.

@ribose-jeffreylau ribose-jeffreylau self-assigned this Nov 9, 2023
hound[bot]
hound bot reviewed Nov 9, 2023
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Gemspec/RequireMFA found in .rubocop.yml 
Error: unrecognized cop Gemspec/RequireMFA found in .rubocop.yml

hound[bot]
hound bot reviewed Nov 9, 2023
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop Gemspec/RequireMFA found in .rubocop.yml 
Error: unrecognized cop Gemspec/RequireMFA found in .rubocop.yml

hound[bot]
hound bot reviewed Nov 9, 2023
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

The configured rubocop version is not supported. 
The configured rubocop version is not supported. 
See a list of supported versions on our docs page.

hound[bot]
hound bot reviewed Nov 9, 2023
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop or department Gemspec/RequireMFA found in .rubocop.yml 
Error: unrecognized cop or department Gemspec/RequireMFA found in .rubocop.yml
Did you mean `Gemspec/RequiredRubyVersion`?

hound[bot]
hound bot reviewed Nov 9, 2023
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: unrecognized cop or department Gemspec/RequireMFA found in .rubocop.yml 
Error: unrecognized cop or department Gemspec/RequireMFA found in .rubocop.yml
Did you mean `Gemspec/RequiredRubyVersion`?

@ribose-jeffreylau ribose-jeffreylau merged commit 5c4946d into master Nov 9, 2023
3 checks passed
@ribose-jeffreylau ribose-jeffreylau deleted the ribose-jeffreylau-67-dot branch November 9, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees

@ribose-jeffreylau ribose-jeffreylau

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout/DotPosition: leading considered harmful
1 participant
@ribose-jeffreylau