Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Configuring tests to be fetched from RPM #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashu-011
Copy link
Collaborator

@ashu-011 ashu-011 commented Jan 9, 2023

No description provided.

@ashu-011 ashu-011 self-assigned this Jan 9, 2023
become: true
become_user: stack
shell: |
scp -r controller-0.ctlplane:~/openstack-dashboard/openstack_dashboard/ "{{ selenium_tests_temp.path }}"/openstack_dashboard ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EliadCohen
Copy link
Collaborator

How do you feel about converting this to a play that runs on a different host and using "import playbook"
This will negate the need to ssh into the controller and will let you use the "fetch" ansible module instead of scp (which you can use regardless btw).

I feel like hard coding ssh commands in ansible and circumventing ansible's mechanism for ssh and host management is a recipe for disaster

@deshipu
Copy link
Collaborator

deshipu commented Jan 10, 2023

@EliadCohen it's a bit tricky, because the files are actually inside a container, and we can't easily run a playbook in there. And to run the tests on the controller node outside of the container, we would need to install a fair number of dependencies that are normally only inside the container.

@EliadCohen
Copy link
Collaborator

@deshipu I understand. We still can have this in a different playbook that references, say, the first member of the "controller" group. That way nothing is hard-coded and the plugin can be run against anything. Including DCN without worrying about the name of the controller nodes. I don't understand where the conflict is....
That said, I am fine with whatever the team wants to do, it is just a thought

become_user: stack
shell: |
scp -r controller-0.ctlplane:~/openstack-dashboard/openstack_dashboard/ "{{ selenium_tests_temp.path }}"/openstack_dashboard ;
scp -r controller-0.ctlplane:~/openstack-dashboard/manage.py "{{ selenium_tests_temp.path }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch didn't work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch wouldn't work in case of recursive directories it seems , we need directories along with the sub-directories as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to find a way to do this using other alternatives such as synchronize module if that works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants