new role for changing engine from local to remote db

.travis.yml

@@ -14,6 +14,7 @@ env:
     # We don't support older versions here. Also upstream doesn't support 4.1
     # when 4.2 is out. https://bugzilla.redhat.com/show_bug.cgi?id=1583222
     - TEST_NAME=4.2
+    - TEST_NAME=promote-db-local-to-remote
 
 # Install python-pip
 addons:

README.md

@@ -44,6 +44,7 @@ This host group is meant for virtual machines hosted by oVirt Engine.
 * [ovirt-engine-cleanup]
 * [ovirt-engine-config]
 * [ovirt-engine-db-dump]
+* [ovirt-engine-local-to-remote-db]
 * [ovirt-engine-remote-db]
 * [ovirt-guest-agent]
 * [ovirt-iso-uploader-conf]
@@ -64,6 +65,7 @@ Under ``tests`` directory, there are playbooks for different oVirt versions
 * tests/test-4.0.yml  (Disabled because of #155)
 * tests/test-4.1.yml
 * tests/test-4.2.yml
+* tests/test-promote-db-local-to-remote.yml
 
 ```sh
 # Install ansible and docker-py
@@ -84,6 +86,7 @@ under ``Dockerfiles`` directory.
 [ovirt-engine-cleanup]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-cleanup/README.md
 [ovirt-engine-config]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-config/README.md
 [ovirt-engine-db-dump]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-db-dump/README.md
+[ovirt-engine-local-to-remote-db]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-local-to-remote-db/README.md
 [ovirt-engine-remote-db]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-remote-db/README.md
 [ovirt-engine-remote-dwh]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-engine-remote-dwh/README.md
 [ovirt-guest-agent]: https://github.com/rhevm-qe-automation/ovirt-ansible/blob/master/roles/ovirt-guest-agent/README.md

examples/inventory/engine_local_to_remote_db.inv

@@ -0,0 +1,11 @@
+[engine:vars]
+
+#### Type flag ####
+# flag that it is engine machine
+  ovirt_type=engine
+
+[database:vars]
+
+#### Type flag ####
+# flag that it is engine machine
+  ovirt_type=remote_db

examples/playbooks/engine_local_to_remote_db.yml

@@ -0,0 +1,7 @@
+---
+# in inventory file engine has ovirt_type=engine, database has ovirt_type=remote_db
+- hosts: engine database
+  vars:
+    ovirt_engine_dwh_to_remote_db: True
+  roles:
+    - ovirt-engine-local-to-remote-db

roles/ovirt-engine-db-dump/README.md

@@ -21,6 +21,7 @@ Role Variables
 ---
 ovirt_engine_db_dump_dwh: [True, False] Dump also DWH database (default: False)
 ovirt_engine_db_dump_start_services: [True, False] Start engine and DWH service after dump (default: True)
+ovirt_engine_db_dump_local_dir: directory on local machine where to store files (default: engine_dump in playbook directory)  
 ```
 
 Dependencies

roles/ovirt-engine-db-dump/defaults/main.yml

@@ -2,4 +2,4 @@
 ovirt_engine_etc_conf_path: "/etc/ovirt-engine/engine.conf.d/"
 ovirt_engine_db_dump_dwh: False
 ovirt_engine_db_dump_start_services: True
-
+ovirt_engine_db_dump_local_dir: "{{ playbook_dir }}/engine_dump"

roles/ovirt-engine-db-dump/tasks/main.yml

@@ -17,7 +17,7 @@
       {{
         ovirt_engine_db_dump_engine_db |
         combine(
-          dict([ item.partition('=')[::2] ])
+          dict([ [item.partition('=')[0], item.partition('=')[2]|regex_replace('\"', '')] ])
         )
       }}
   with_items: "{{ cmd.stdout_lines|list }}"
@@ -35,7 +35,7 @@
       {{
         ovirt_engine_db_dump_dwh_db |
         combine(
-          dict([ item.partition('=')[::2] ])
+          dict([ [item.partition('=')[0], item.partition('=')[2]|regex_replace('\"', '')] ])
         )
       }}
   with_items: "{{ cmd.stdout_lines|list }}"
@@ -51,56 +51,63 @@
     - ovirt-engine
 
 # get engine and dwh database dumps
+- name: enable sudo without tty
+  lineinfile:
+    path: /etc/sudoers
+    state: present
+    regexp: '^Defaults *requiretty$'
+    line: 'Defaults    !requiretty'
+
+- name: get postgres path
+  become: yes
+  become_user: postgres
+  shell: echo $HOME
+  register: pgpath
+  tags:
+    - skip_ansible_lint
+
 - name: create local dir
   local_action:
-    file path={{ playbook_dir }}/engine_dump state=directory
+    file path={{ ovirt_engine_db_dump_local_dir }} state=directory
 
 - name: get dump of engine database
   become: yes
   become_user: postgres
-  shell: pg_dump -F c {{ ovirt_engine_db_dump_engine_db['ENGINE_DB_DATABASE'] }} -f engine.sql
-  tags:
-    - skip_ansible_lint
+  postgresql_db:
+    name: "{{ ovirt_engine_db_dump_engine_db['ENGINE_DB_DATABASE'] }}"
+    target: "{{ pgpath.stdout }}/engine.sql"
+    state: dump
 
 - name: get dump of dwh database
   become: yes
   become_user: postgres
-  shell: pg_dump -F c {{ ovirt_engine_db_dump_dwh_db['DWH_DB_DATABASE'] }} -f dwh.sql
+  postgresql_db:
+    name: "{{ ovirt_engine_db_dump_dwh_db['DWH_DB_DATABASE'] }}"
+    target: "{{ pgpath.stdout }}/dwh.sql"
+    state: dump
   when: ovirt_engine_db_dump_dwh == True
-  tags:
-    - skip_ansible_lint
 
 # print variables to file
 - name: print engine variables to file
   local_action:
-        copy content="{{ ovirt_engine_db_dump_engine_db }}" dest="{{ playbook_dir }}/engine_dump/engine_variables.json"
+        copy content="{{ ovirt_engine_db_dump_engine_db }}" dest="{{ ovirt_engine_db_dump_local_dir }}/engine_variables.json"
 
 - name: print DWH variables to file
   local_action:
-        copy content="{{ ovirt_engine_db_dump_dwh_db }}" dest="{{ playbook_dir }}/engine_dump/dwh_variables.json"
+        copy content="{{ ovirt_engine_db_dump_dwh_db }}" dest="{{ ovirt_engine_db_dump_local_dir }}/dwh_variables.json"
   when: ovirt_engine_db_dump_dwh == True
 
 # copy files to localhost
-- name: get postgres path
-  become: yes
-  become_user: postgres
-  become_method: su
-  become_flags: "-"
-  shell: echo $HOME
-  register: pgpath
-  tags:
-    - skip_ansible_lint
-
 - name: copy engine dump to local
   fetch:
     src: "{{ pgpath.stdout }}/engine.sql"
-    dest: "{{ playbook_dir }}/engine_dump/engine.sql"
+    dest: "{{ ovirt_engine_db_dump_local_dir }}/engine.sql"
     flat: yes
 
 - name: copy dwh dump to local
   fetch:
     src: "{{ pgpath.stdout }}/dwh.sql"
-    dest: "{{ playbook_dir }}/engine_dump/dwh.sql"
+    dest: "{{ ovirt_engine_db_dump_local_dir }}/dwh.sql"
     flat: yes
   when: ovirt_engine_db_dump_dwh == True
 

roles/ovirt-engine-local-to-remote-db/README.md

@@ -0,0 +1,74 @@
+oVirt Engine Local DB to Remote
+===============================
+
+- dump engine/dwh database on engine
+- create databases/users on remote server and import dump files, install postgres if neccessary
+- set engine from local db to remote
+
+Target systems
+--------------
+
+* engine
+* database
+
+Requirements
+------------
+
+Preinstalled engine with local DB.
+Preinstalled clean el7/linux based operating system on remote server.
+
+Role Variables
+--------------
+
+```yaml
+---
+ovirt_engine_to_remote_db: [True, False] Change from local to remote engine database (default: True)
+ovirt_engine_dwh_to_remote_db: [True, False] Change from local to remote DWH database (default: False)
+
+ovirt_engine_reset: [True, False] True - set back engine to local db (default: False)
+ovirt_engine_drop_local_db: [True, False] Drop local databases after engine is set to remote db, dump will be stored (default: True)
+```
+
+Dependencies
+------------
+
+Role ovirt-engine-db-dump
+Role ovirt-engine-remote-db
+
+Example Playbook
+----------------
+
+```yaml
+---
+# in inventory file engine has ovirt_type=engine, database has ovirt_type=remote_db
+- hosts: engine database
+  vars:
+    ovirt_engine_dwh_to_remote_db: True
+    ovirt_engine_version: "4.2"
+    # var for ovirt-common, this is not a must for ovirt <= 4.1
+    ovirt_engine_drop_local_db: False
+  roles:
+    - ovirt-engine-local-to-remote-db
+```
+
+Example Inventory
+----------------
+
+```yaml
+---
+[engine]
+engine1.example.com
+[engine:vars]
+ovirt_type=engine
+
+[database]
+db1.example.com
+[database:vars]
+ovirt_type=remote_db
+```
+
+Author Information
+------------------
+
+Lucie Leistnerova
+[email protected]

roles/ovirt-engine-local-to-remote-db/defaults/main.yml

@@ -0,0 +1,12 @@
+---
+ovirt_engine_version: "4.1"
+ovirt_engine_reset: False
+ovirt_engine_to_remote_db: True
+ovirt_engine_dwh_to_remote_db: False
+ovirt_engine_etc_conf_files: 
+  - /etc/ovirt-engine/engine.conf.d/10-setup-database.conf 
+  - /etc/ovirt-engine/engine.conf.d/10-setup-dwh-database.conf
+  - /etc/ovirt-engine-dwh/ovirt-engine-dwhd.conf.d/10-setup-database.conf
+ovirt_engine_etc_conf_files_aaa: 
+  - /etc/ovirt-engine/aaa/internal.properties
+ovirt_engine_drop_local_db: True

roles/ovirt-engine-local-to-remote-db/meta/main.yml

@@ -0,0 +1,13 @@
+---
+galaxy_info:
+  author: "Lucie Leistnerova"
+  description: "oVirt change engine/dwh local to remote database"
+  company: "Red Hat"
+  license: "GPLv3"
+  min_ansible_version: 2.0
+  platforms:
+  - name: EL
+    versions:
+    - all
+  galaxy_tags:
+    - migration

roles/ovirt-engine-local-to-remote-db/tasks/main.yml

@@ -0,0 +1,120 @@
+---
+- name: set engine variables
+  set_fact:
+    engine_ip: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"
+  delegate_to: "{{ item }}"
+  delegate_facts: True
+  with_items: "{{ groups['all'] }}"
+  when: ovirt_type == "engine"
+
+- name: set db variables
+  set_fact:
+    remote_db_ip: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"
+  delegate_to: "{{ item }}"
+  delegate_facts: True
+  with_items: "{{ groups['all'] }}"
+  when: ovirt_type == "remote_db"
+
+# first dump databases on engine and get connection variables
+- name: dump databases
+  include_role:
+    name: ovirt-engine-db-dump
+  vars:
+    ovirt_engine_db_dump_dwh: "{{ ovirt_engine_dwh_to_remote_db }}"
+    ovirt_engine_db_dump_start_services: False
+    ovirt_engine_db_dump_local_dir: "{{ playbook_dir }}/engine_dump"
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_reset == False
+
+- name: get engine variables from file
+  include_vars:
+    file: "{{ playbook_dir }}/engine_dump/engine_variables.json"
+    name: ovirt_engine_db_dump_engine_db
+  when:
+    - ovirt_engine_to_remote_db == True
+    - ovirt_engine_reset == False
+
+- name: get DWH variables from file
+  include_vars:
+    file: "{{ playbook_dir }}/engine_dump/dwh_variables.json"
+    name: ovirt_engine_db_dump_dwh_db
+  when:
+    - ovirt_engine_dwh_to_remote_db == True
+    - ovirt_engine_reset == False
+
+# create databases on remote server and import data
+- name: create databases and import data
+  include_role:
+    name: ovirt-engine-remote-db
+  vars:
+    ovirt_engine_remote_db_port: "{{ ovirt_engine_db_dump_engine_db['ENGINE_DB_PORT'] }}"
+    ovirt_engine_db_name: "{{ ovirt_engine_db_dump_engine_db['ENGINE_DB_DATABASE'] }}"
+    ovirt_engine_db_user: "{{ ovirt_engine_db_dump_engine_db['ENGINE_DB_USER'] }}"
+    ovirt_engine_db_password: "{{ ovirt_engine_db_dump_engine_db['ENGINE_DB_PASSWORD'] }}"
+    ovirt_engine_remote_db: "{{ ovirt_engine_to_remote_db }}"
+    ovirt_engine_dwh_remote_db: "{{ ovirt_engine_dwh_to_remote_db }}"
+    ovirt_engine_dwh_db_name: "{{ ovirt_engine_db_dump_dwh_db['DWH_DB_DATABASE'] }}"
+    ovirt_engine_dwh_db_user: "{{ ovirt_engine_db_dump_dwh_db['DWH_DB_USER'] }}"
+    ovirt_engine_dwh_db_password: "{{ ovirt_engine_db_dump_dwh_db['DWH_DB_PASSWORD'] }}"
+    ovirt_engine_remote_db_force: True
+    ovirt_engine_remote_db_dump: "{{ playbook_dir }}/engine_dump/engine.sql"
+    ovirt_engine_remote_db_dwh_dump: "{{ playbook_dir }}/engine_dump/dwh.sql"
+    ovirt_engine_remote_db_access:
+      -
+        type: host
+        address: "{{ engine_ip }}/32"
+        method: md5
+  when:
+    - ovirt_type == "remote_db"
+    - ovirt_engine_reset == False
+
+# set engine from local to remote db
+- include: set-engine.yml
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_reset == False
+
+# check engine running
+- name: check if ovirt-engine running (health page)
+  uri:
+    url: "http://{{ ansible_fqdn }}/ovirt-engine/services/health"
+    status_code: 200
+  register: ovirt_engine_status
+  retries: 2
+  delay: 5
+  until: ovirt_engine_status|success
+  ignore_errors: True
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_reset == False
+
+# engine is not running reset engine back to local
+- name: engine not running - set back to local
+  set_fact:
+    ovirt_engine_drop_local_db: False
+    ovirt_engine_reset: True
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_reset == False
+    - ovirt_engine_status|failed
+
+# reset engine back to local db
+- include: reset-engine.yml
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_reset == True
+
+# clean
+- name: remove dump files from local
+  local_action:
+    file path={{ playbook_dir }}/engine_dump state=absent
+  when:
+    - ovirt_engine_reset == False
+
+# drop databases
+- include: remove-local-db.yml
+  when:
+    - ovirt_type == "engine"
+    - ovirt_engine_drop_local_db == True
+    - ovirt_engine_reset == False