🙉Monke Good #13
Merged
🙉Monke Good #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
awtkns
commented
Nov 17, 2023
•
awtkns
commented
- improve test names (shown below)
- make pytest output be verbose by default
- add ability to load runners by path
- improved code loading
|
Maybe outside scope but should get the id in the name or folder somehow for spot testing single failures |
bananalyzer/__main__.py
Outdated
Comment on lines
111
to
126
| def find_decorated_scrapers(file_path: Path) -> List[AgentRunnerClass]: | ||
| with open(file_path, "r") as source: | ||
| node = ast.parse(source.read()) | ||
|
|
||
| runners: List[AgentRunnerClass] = [] | ||
| for clazz in [n for n in node.body if isinstance(n, ast.ClassDef)]: | ||
| if "AgentRunner" in [getattr(base, "id", "") for base in clazz.bases]: | ||
| runners.append( | ||
| AgentRunnerClass( | ||
| class_name=clazz.name, | ||
| class_path=str(file_path), | ||
| class_def=clazz, | ||
| ) | ||
| ) | ||
|
|
||
| return runners |
There was a problem hiding this comment.
Let's update the README with this new functionality
|
What's with the deletion of the test? |
yes,
its a test in the wrong directory, the null agent test file is not needed anymore with the code analyzsis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.