Refactor invoker following the rust conventions #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic mods Introduced interface for InvokerStatusReader
slinkydeveloper
force-pushed
the
refactor-invoker
branch
from
afe03d7
to
382e458
Compare
tillrohrmann
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
LGTM. Thanks for improving the structure of the invoker package @slinkydeveloper. +1 for merging.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #526
This PR is a bit of collection of ideas I had to improve the Invoker code, which is currently a bit complicated and hard to follow. This PR follows the conventions described in #392. I still did not split the module between "api" and "impl", but it should be easy to do as a next step.