Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8/n] Reconfigure logs if default log replication has changed #2542

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[8/n] Reconfigure logs if default log replication has changed #2542

merged 1 commit into from
Jan 27, 2025
+12 −0

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jan 24, 2025 •
edited
Loading

No description provided.

This was referenced Jan 24, 2025
Merged
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

Test Results

  7 files  ±0    7 suites  ±0   2m 52s ⏱️ +16s
 45 tests ±0   44 ✅ ±0  1 💤 ±0  0 ❌ ±0 
174 runs  +2  171 ✅ +2  3 💤 ±0  0 ❌ ±0 

Results for commit 49c6994. ± Comparison against base commit 3bd2aa1.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)
dev.restate.sdktesting.tests.RawHandler ‑ rawHandler(Client)

dev.restate.sdktesting.tests.RunRetry ‑ withExhaustedAttempts(Client)
dev.restate.sdktesting.tests.RunRetry ‑ withSuccess(Client)

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman mentioned this pull request Jan 24, 2025
Draft
tillrohrmann
tillrohrmann approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging :-)

@AhmedSoliman AhmedSoliman changed the title [8/n] Reconfigure logs if default replicatation has changed [8/n] Reconfigure logs if default log replication has changed Jan 27, 2025
@AhmedSoliman AhmedSoliman merged commit 49c6994 into main Jan 27, 2025
25 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2542 branch January 27, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann