Add trace-level logging for Metadata API operations #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 7 files ±0 7 suites ±0 2m 48s ⏱️ - 1m 30s Results for commit fbaf6df. ± Comparison against base commit 7377bf3. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
muhamadazmy
reviewed
Jan 27, 2025
| @@ -84,7 +85,7 @@ async fn delete_key( | |||
| } | |||
|
|
|||
| // todo(azmy): implement both PreconditionHeader and VersionHeader | |||
| // as extractors after updating axium to version > 0.8 | |||
| // as extractors after updating axum to version > 0.8 | |||
There was a problem hiding this comment.
Suggested change
| // as extractors after updating axum to version > 0.8 | |
| // as extractors after updating axum to version > 0.8 |
| key, | ||
| version, | ||
| precondition, | ||
| String::from_utf8_lossy(&value), |
There was a problem hiding this comment.
I am wondering if the value should be printed in the trace logs. it's probably not an issue during testing but in general this can be big and also binary. Maybe drop the value from the logs and just print the len of it. This can save us a .clone() as well of the value.
| Ok(value) => trace!( | ||
| "Get key: {:?} -> value: {} @{}", | ||
| key, | ||
| String::from_utf8_lossy(&value.value), |
There was a problem hiding this comment.
Same thought over having the value in the logs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change to aid in understanding distributed test runs.