Adding placements to partition table #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
Closed
muhamadazmy
force-pushed
the
pr2464
branch
5 times, most recently
from
7634241 to
528f9c3
Compare
muhamadazmy
changed the title
muhamadazmy
force-pushed
the
pr2464
branch
2 times, most recently
from
53bfd34 to
6a7bdbe
Compare
Closed
muhamadazmy
force-pushed
the
pr2464
branch
2 times, most recently
from
f9f124b to
7c71a42
Compare
muhamadazmy
changed the title
muhamadazmy
force-pushed
the
pr2464
branch
2 times, most recently
from
f5bd595 to
0286b87
Compare
muhamadazmy
commented
Jan 13, 2025
There was a problem hiding this comment.
Thanks for introducing the ReplicaGroup @muhamadazmy. The changes look good to me :-) I had a suggestion to rename ReplicaGroup into something like PartitionPlacement to start with the renaming process. One additional question was around the equality definition of ReplicaGroup. I've seen that in Partition you use a different definition than what PartialEq gives us. Should this be aligned and documented?
|
Thank you @tillrohrmann for your very insightful review and comments. I totally agree over the rename and the implementation of PartialEq for the |
muhamadazmy
force-pushed
the
pr2464
branch
3 times, most recently
from
f3e6860 to
49bde5f
Compare
muhamadazmy
changed the title
Summary: Partition table now includes the placement of each partition. PartitionPlacement, representing the set of nodes where the partition should run, with the first node in the group designated as the leader.
tillrohrmann
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding placements to partition table
Summary:
Partition table now includes the placement of each partition. PartitionPlacement, representing the set of nodes where the partition should run, with the first node in the group designated as the leader.
Stack created with Sapling. Best reviewed with ReviewStack.