Fix schemar's type in rocksdb config #2329
Merged
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
muhamadazmy
reviewed
Nov 20, 2024
| @@ -96,7 +96,7 @@ pub struct RocksDbOptions { | |||
| /// Max size of info LOG file | |||
| /// | |||
| /// Default: 64MB | |||
| #[cfg_attr(feature = "schemars", schemars(with = "Option<ByteCount>"))] | |||
| #[cfg_attr(feature = "schemars", schemars(with = "Option<NonZeroByteCount>"))] | |||
There was a problem hiding this comment.
Sorry about that. LGTM!
muhamadazmy
approved these changes
Nov 20, 2024
Adds a configuration key in common to configure tokio-console subscriber bind address (support unix-sockets btw). Moreover, this lets tokio-console subscriber bind on all interfaces by default to make it easy to introspect restate-server running in docker containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.