Avoid blocking on InvokerService creation #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the wait for logs version, Everything runs in parallel
|
…trol loop Summary: - Improve tracing of ControlProcessors commands - Run the spawn of partition processors concurrently
Summary: While testing I noticed that InvokerService creations takes around 25ms (on my machine) to be created with `InvokerService::from_options` I traced the delay to a single line of code here https://github.com/restatedev/restate/blob/1cb01203f18bfc6ddb5fe4c45f6697799a79c27e/crates/service-client/src/http.rs#L73 My first thought was to cache the `HttpsConnectorBuilder` but this won't work because `HttpsConnectorBuilder` is not clonable hence what i did instead is to move the InvkerService creation to the async trask and use a `JoinSet` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid blocking on InvokerService creation
Summary:
While testing I noticed that InvokerService creations takes
around 25ms (on my machine) to be created with
InvokerService::from_optionsI traced the delay to a single line of code here
restate/crates/service-client/src/http.rs
Line 73 in 1cb0120
My first thought was to cache the
HttpsConnectorBuilderbut this won't work becauseHttpsConnectorBuilderis notclonable hence what i did instead is to move the InvkerService creation to the async trask and use a
JoinSetinsteadStack created with Sapling. Best reviewed with ReviewStack.