Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bifrost] SpreadSelector initial implementation #1976

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[Bifrost] SpreadSelector initial implementation #1976

merged 2 commits into from
Sep 19, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Sep 19, 2024 •
edited
Loading

Implements a flood selector (selects all writeable nodes in the effective nodeset).

Stack created with Sapling. Best reviewed with ReviewStack.

@AhmedSoliman AhmedSoliman mentioned this pull request Sep 19, 2024
Merged
@AhmedSoliman AhmedSoliman changed the title SpreadSelector [Bifrost] SpreadSelector initial implementation Sep 19, 2024
@AhmedSoliman
[Bifrost] Initial NodeSetChecker implementation
8571725 
This introduces ReplicationChecker utility that performs write and f-majority quorum checks. Note that the current implementation is not LocationScope aware and will only consider node-level scope.
The utility is designed to allow attaching any attribute type to nodes in the nodeset and run the check against the set of nodes that match a predicate against those attributes.
@AhmedSoliman AhmedSoliman marked this pull request as ready for review September 19, 2024 11:51
@AhmedSoliman
[Bifrost] SpreadSelector initial implementation
faff5b9 
Implements a flood selector (selects all writeable nodes in the effective nodeset).
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Test Results

  5 files   - 10    5 suites   - 10   2m 38s ⏱️ - 15m 32s
 45 tests +39   45 ✅ +39  0 💤 ±0  0 ❌ ±0 
114 runs  +96  114 ✅ +96  0 💤 ±0  0 ❌ ±0 

Results for commit faff5b9. ± Comparison against base commit ee1b745.

This pull request removes 6 and adds 45 tests. Note that renamed tests count towards both. 
dev.restate.e2e.JavaAwakeableTest ‑ generate(Client)
dev.restate.e2e.KtInterpreterTest ‑ simple(int)
dev.restate.e2e.NodeAwakeableTest ‑ generate(Client)
dev.restate.e2e.NodeInterpreterTest ‑ simple(int)
dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingCall(Client, URL)
dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingOneWayCall(Client, URL)

dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[1]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[2]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[3]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[1]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[2]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[3]
dev.restate.sdktesting.tests.Ingress ‑ headersPassThrough(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeSend(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeService(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeVirtualObject(URL, Client)
…

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman merged commit faff5b9 into main Sep 19, 2024
23 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1976 branch September 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @muhamadazmy