Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace infinite retries with writing to background appender when announcing leadership #2333

Closed
Tracked by #1800
tillrohrmann opened this issue Nov 20, 2024 · 0 comments · Fixed by #2346
Closed
Tracked by #1800

Replace infinite retries with writing to background appender when announcing leadership #2333

tillrohrmann opened this issue Nov 20, 2024 · 0 comments · Fixed by #2346
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

No description provided.

@tillrohrmann tillrohrmann mentioned this issue Nov 20, 2024
Open
@tillrohrmann tillrohrmann self-assigned this Nov 20, 2024
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Nov 21, 2024
@tillrohrmann
Remove infinite retry policy when announcing the leadership
715ef2c 
Instead of retrying infinitely in the LeadershipState, we are now spawning a
background appender and hand the announce leadership message over. Additionally,
we are now monitoring the health of the appender task to escalate potential
failures which would then result in shutting the PP down and let the PPM handle
the situation.

This fixes restatedev#2333.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Nov 21, 2024
@tillrohrmann
Remove infinite retry policy when announcing the leadership
15e2c3c 
Instead of retrying infinitely in the LeadershipState, we are now spawning a
background appender and hand the announce leadership message over. Additionally,
we are now monitoring the health of the appender task to escalate potential
failures which would then result in shutting the PP down and let the PPM handle
the situation.

This fixes restatedev#2333.
@tillrohrmann tillrohrmann mentioned this issue Nov 21, 2024
Closed
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Nov 22, 2024
@tillrohrmann
Remove infinite retry policy when announcing the leadership
1f99db0 
Instead of retrying infinitely in the LeadershipState, we are now spawning a
background appender and hand the announce leadership message over. Additionally,
we are now monitoring the health of the appender task to escalate potential
failures which would then result in shutting the PP down and let the PPM handle
the situation.

This fixes restatedev#2333.
@tillrohrmann tillrohrmann mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tillrohrmann