Remove infinite retry policy when announcing the leadership #2346
+1,373
−1,233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of retrying infinitely in the LeadershipState, we are now spawning a background appender and hand the announce leadership message over. Additionally, we are now monitoring the health of the appender task to escalate potential failures which would then result in shutting the PP down and let the PPM handle the situation. This fixes restatedev#2333.
This commit moves the LeaderState and the SelfProposer into their own modules in order to make the leadership module easier to reason about.
This commit fixes the problem where the run future of the LeaderState was losing action effects if handle_action_effects would be awaiting and another tokio::select arm would trigger in the PP event loop. The solution is to pass the action effects back to the PP event loop and then handle them in the select arm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of retrying infinitely in the LeadershipState, we are now spawning a
background appender and hand the announce leadership message over. Additionally,
we are now monitoring the health of the appender task to escalate potential
failures which would then result in shutting the PP down and let the PPM handle
the situation.
This fixes #2333.
The second commit is only moving code into separate modules.