-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally (by default) download & build stripped arrow as part of rerun_sdk #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ires DOWNLOAD_EXTRACT_TIMESTAMP
Wumpf
added
enhancement
New feature or request
🏹 arrow
concerning arrow
🌊 C++ API
C/C++ API specific
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Oct 27, 2023
Wumpf
commented
Oct 27, 2023
jleibs
reviewed
Oct 27, 2023
jleibs
reviewed
Oct 27, 2023
jleibs
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on linux -- works for me and looks great. Much as I love pixi this really lowers the bar for ease of integration.
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏹 arrow
concerning arrow
🌊 C++ API
C/C++ API specific
enhancement
New feature or request
exclude from changelog
PRs with this won't show up in CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Confirmed to be working on Linux, Mac and Windows. On windows also made sure this works with debug runtime and experimented a bit with Visual Studio setups. Also checked Windows against the external sample, see rerun-io/cpp-example-opencv-eigen#8
Made improvements to our CMakeLists files overall. Notably we no longer need
DOWNLOAD_EXTRACT_TIMESTAMP ON
to suppress warnings - idea from rerun-io/cpp-example-opencv-eigen#6, setting a range for the cmake version fixes itDrawbacks:
Advantages:
It's still worth considering if we should ship prebuilt debug & release arrow dlls instead.
TODO: We need to document this new behavior and how to turn it off in the respective doc pages. By default the user no longer needs to install libArrow with this.
Important CMake options that need documenting (can partially copy& paste this!):
RERUN_ARROW_LINK_SHARED
RERUN_ARROW_EXTERNAL_PROJECT
(new!)find_package
== old behaviorRERUN_C_LIB
Checklist