Implement Download modes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempusfrangit
requested review from
anotherjesse,
philandstuff and
technillogue
tempusfrangit
force-pushed
the
download-modes
branch
3 times, most recently
from
5268af2
to
c03670c
Compare
philandstuff
approved these changes
Nov 15, 2023
tempusfrangit
force-pushed
the
download-modes
branch
from
c03670c
to
b7c29d5
Compare
Imeplement a download modes framework that allows specifying a mechanism to download. This commit implements "buffer" and "tar-extract" which mirror the original behaviors of pget. The '-x'/'--extract' option automatically sets the `tar-extract` mode. tar-extract mode simply wraps the buffer mode for now. Behavior and CLI options are not modified in this commit
tempusfrangit
force-pushed
the
download-modes
branch
from
b7c29d5
to
d3329e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the download mode framework with
bufferandtar-extractto start. This allows us to expand the modes we want to operate in without impacting defaults or other users.