Add integration tests around stream redirection #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure we don't have regressions like that seen in `v0.11.4`. The tests here are somewhat contrived, but based on how some known models work that failed when stream redirection didn't work as expected.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
8W9aG
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Really amazing work dan, very impressive, only suggestion I might have would be to add a few comments about the issues the test itself is trying to fix, in the sense that looking at the test its not clear to me why it should ever fail, but thats just a nice to have
Thank you, @8W9aG! I'll get some comments in place 👍🏼 |
8W9aG
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure we don't have regressions like that seen in
v0.11.5.The tests here are somewhat contrived, but based on how some known models work that failed when stream redirection didn't work as expected, and in fact they all fail when run against
v0.11.5.Connected to PLAT-410