Support async predictors (✨ again ✨) #2025
Merged
+415
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meatballhat
force-pushed
the
revert-2022-revert-support-async-predict
branch
from
25142fa
to
0440eba
Compare
|
(now rebased with the stream redirection integration tests) |
so that the sync stream redirector context is only entered once, as this is a known source of problems associated with stdout/stderr orphaning.
meatballhat
force-pushed
the
revert-2022-revert-support-async-predict
branch
from
0440eba
to
c803aef
Compare
meatballhat
force-pushed
the
revert-2022-revert-support-async-predict
branch
from
575f2eb
to
f33037a
Compare
erbridge
reviewed
Oct 29, 2024
* Exclude invalid output paths from infrastructure errors Closes PLAT-380 * Fix words given pluralization Co-authored-by: F <[email protected]> Signed-off-by: Dan Buch <[email protected]> --------- Signed-off-by: Dan Buch <[email protected]> Co-authored-by: F <[email protected]>
erbridge
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2022 to restore #2010
plus:
Closes PLAT-373