Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added viem/ethers/uprovider examples #99

Merged
merged 12 commits into from
Sep 22, 2023
Merged

Added viem/ethers/uprovider examples #99

merged 12 commits into from
Sep 22, 2023

Conversation

ignaciosantise
Copy link
Collaborator

@ignaciosantise ignaciosantise commented Sep 18, 2023 •
edited
Loading

Summary

Added new examples using:

  • WalletConnectModal + Viem -> Check implementation here
  • WalletConnectModal + Ethers -> Check implementation here
  • WalletConnectModal + Universal Provider -> Check implementation here

Pending:

@ignaciosantise ignaciosantise mentioned this pull request Sep 20, 2023
Merged
@ignaciosantise ignaciosantise marked this pull request as ready for review September 20, 2023 15:28
crypblizz8
crypblizz8 reviewed Sep 22, 2023
View reviewed changes
dapps/ModalEthers/src/App.tsx Outdated

const amount = sanitizeHex(numberToHex(0.0001));
const transaction = {
to: '0x4B599F4a9F089cEE3ab875c96987087B25e501F3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is this?

crypblizz8
crypblizz8 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@crypblizz8 crypblizz8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we can iterate later.

After 0x address question is solved, we can merge

@ignaciosantise ignaciosantise merged commit ac65a4b into main Sep 22, 2023
2 of 3 checks passed
@ignaciosantise ignaciosantise deleted the test/viem-wagmi branch September 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypblizz8 crypblizz8 crypblizz8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignaciosantise @crypblizz8