-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement notify api to rn sample wallet #124
Conversation
022d24c
to
ca321c6
Compare
wallets/rn_cli_wallet/src/components/components/AccountButton.tsx
Outdated
Show resolved
Hide resolved
wallets/rn_cli_wallet/src/components/components/ConnectOverlay.tsx
Outdated
Show resolved
Hide resolved
wallets/rn_cli_wallet/src/screens/SubscriptionDetailsScreen.tsx
Outdated
Show resolved
Hide resolved
wallets/rn_cli_wallet/ios/assets/src/assets/ethCalculatorBG.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ignaciosantise Can we merge if all are good?
I think we might need to refactor navigation TS definitions since the navigate
function doesn't respect the current TS, idk if it's an issue with React Navigation (since we have nested stacks, TS can find it too complicated and broken) or our setup should be improved. I'd prefer to handle this later at this moment.
Just some comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
No description provided.