Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement notify api to rn sample wallet #124

Merged
merged 54 commits into from
Feb 27, 2024
Merged

Conversation

enesozturk
Copy link
Contributor

No description provided.

@enesozturk enesozturk marked this pull request as ready for review February 27, 2024 09:09
Copy link
Contributor Author

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ignaciosantise Can we merge if all are good?

I think we might need to refactor navigation TS definitions since the navigate function doesn't respect the current TS, idk if it's an issue with React Navigation (since we have nested stacks, TS can find it too complicated and broken) or our setup should be improved. I'd prefer to handle this later at this moment.

@ignaciosantise
Copy link
Collaborator

Just some comments:

  1. Can you check if we can get rid of the expo dependency? We are not currently using it apart from the expo babel config. I think you could replace that preset with the one used in react native by default: presets: ['module:@react-native/babel-preset'],
  2. Remove react-native-pager-view since its no longer used. (remember to run pod-install after removing it)

Copy link
Collaborator

@ignaciosantise ignaciosantise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@enesozturk enesozturk merged commit 1741189 into main Feb 27, 2024
@ignaciosantise ignaciosantise deleted the feat/w3i-sdk-example branch September 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants