feat: read state #423
Merged
feat: read state #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
force-pushed
the
feat/read-status
branch
from
773a85b to
7e41520
Compare
chris13524
commented
Mar 18, 2024
| @@ -313,7 +316,7 @@ pub struct SubscriptionGetNotificationsRequestAuth { | |||
| /// did:web of app domain | |||
| pub app: DidWeb, | |||
| #[serde(flatten)] | |||
| #[validate] | |||
| #[validate(nested)] | |||
There was a problem hiding this comment.
Fix for silent breaking change in 0.17.0. See Keats/validator#307
chris13524
commented
Mar 18, 2024
| @@ -92,7 +92,7 @@ sqlx = { version = "0.7.3", features = ["runtime-tokio-native-tls", "postgres", | |||
| wiremock = "0.5.19" | |||
| itertools = "0.11.0" | |||
| sha3 = "0.10.8" | |||
| validator = { version = "0.16.1", features = ["derive"] } | |||
| validator = { version = "0.17.0", features = ["derive"] } | |||
There was a problem hiding this comment.
Upgrade to support custom validators accepting Option<T> instead of T, allowing the ability to validate the state of the Option and not just T.
Some may consider this change a bug
chris13524
force-pushed
the
feat/read-status
branch
from
9397b45 to
5de4386
Compare
chris13524
changed the base branch from
main
to
fix/errors-excluded-from-metrics
nopestack
approved these changes
Mar 20, 2024
geekbrother
reviewed
Mar 20, 2024
geekbrother
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements support for marking notifications as read as per the specs.
Resolves #425
Subsequent PRs will address the remaining TODOs at the end of integration.rs
How Has This Been Tested?
New tests
Due Diligence