Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no 500 on app domain conflict #215

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix: no 500 on app domain conflict #215

merged 2 commits into from
Nov 17, 2023

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Nov 16, 2023 •
edited
Loading

Description

  • Fixes the server error when app domain is already taken by another project ID
  • Tests the idempotency of /subscribe-topic endpoint

Resolves #199

How Has This Been Tested?

Automated tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Nov 16, 2023
@chris13524 chris13524 merged commit 7532c74 into main Nov 17, 2023
18 of 20 checks passed
@chris13524 chris13524 deleted the fix/no-500-on-app-domain-conflict branch November 17, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

@xav xav Awaiting requested review from xav

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: 500 error from duplicate app domain
2 participants
@chris13524 @geekbrother