Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error logs #211

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: error logs #211

merged 1 commit into from
Nov 15, 2023

Conversation

chris13524
Copy link
Member

Description

Changes warn logs to error logs since these are generally catastrophic errors and should never happen.

Also add TODOs

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Nov 15, 2023
geekbrother
geekbrother approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think some of TODOs should be task/issues to track them in a backlog.

@chris13524 chris13524 merged commit 257aaab into main Nov 15, 2023
10 checks passed
@chris13524 chris13524 deleted the chore/error-logs branch November 15, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris13524 @geekbrother