Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils/yaml): Remove jinja2 block delimiters from YAML #26682

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Jan 16, 2024

Changes

The default jinja2 block delimiter is {% ... %}. This change strips them out of the YAML files.

Context

#18470

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests

@onedr0p
Copy link
Contributor Author

onedr0p commented Jan 16, 2024

Updated, hopefully using the existing test is acceptable.

@secustor secustor added this pull request to the merge queue Jan 16, 2024
@secustor secustor changed the title fix(utils/yaml): Remove jinja2 block delimiters from YAML feat(utils/yaml): Remove jinja2 block delimiters from YAML Jan 16, 2024
Merged via the queue into renovatebot:main with commit 36604f1 Jan 16, 2024
36 checks passed
@onedr0p onedr0p deleted the patch-1 branch January 16, 2024 21:07
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.137.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants