feat: add docker-socket-host-path input
#862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Aug 24, 2024
src/input.ts
Outdated
| @@ -73,6 +73,10 @@ class Input { | |||
| return core.getInput('mount-docker-socket') === 'true'; | |||
| } | |||
|
|
|||
| dockerSocketHostPath(): string { | |||
| return core.getInput('docker-socket-host-path'); | |||
src/renovate.ts
Outdated
Comment on lines
87
to
88
| const dockerSocketStat = await fs.stat(this.input.dockerSocketHostPath()); | ||
| return dockerSocketStat.gid.toString(); |
There was a problem hiding this comment.
If this gets merged, I'll create a separate PR that leverages the stat done as part of verification to also get the gid.
- Adds `docker-socket-host-path` input, allowing users to override the location of the docker socket on their host. Defaults to `/var/run/docker.sock`.
justfalter
force-pushed
the
docker-socket-host-path
branch
from
8263fc6
to
328efab
Compare
|
Any additional thoughts, @viceice? |
viceice
reviewed
Aug 27, 2024
viceice
approved these changes
Sep 30, 2024
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Sep 30, 2024
##### [`vv40.3.0](https://github.com/renovatebot/github-action/releases/tag/v40.3.0) ##### Features - add `docker-socket-host-path` input ([#862](renovatebot/github-action#862)) ([c0afe86](renovatebot/github-action@c0afe86))
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Sep 30, 2024
##### [`vv40.3.0](https://github.com/renovatebot/github-action/releases/tag/v40.3.0) ##### Features - add `docker-socket-host-path` input ([#862](renovatebot/github-action#862)) ([c0afe86](renovatebot/github-action@c0afe86))
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Sep 30, 2024
##### [`vv40.3.0](https://github.com/renovatebot/github-action/releases/tag/v40.3.0) ##### Features - add `docker-socket-host-path` input ([#862](renovatebot/github-action#862)) ([c0afe86](renovatebot/github-action@c0afe86))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-socket-host-pathinput, allowing users to override the location of the docker socket on their host. Defaults to/var/run/docker.sock.