docs(readme): rewrite #846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jun 5, 2024
Co-authored-by: Michael Kriese <[email protected]>
HonkingGoose
commented
Jun 5, 2024
HonkingGoose
commented
Jun 5, 2024
HonkingGoose
commented
Jun 5, 2024
viceice
reviewed
Jun 15, 2024
| @@ -353,9 +352,9 @@ For example: | |||
|
|
|||
| ## Environment Variables | |||
|
|
|||
| If you wish to pass through environment variables through to the Docker container that powers this action you need to prefix the environment variable with `RENOVATE_`. | |||
| To pass through environment variables through to the Docker container that powers this action, you must prefix the environment variable with `RENOVATE_`. | |||
There was a problem hiding this comment.
we should remove this must prefix, it's totally wrong and we should not suggest that.
There was a problem hiding this comment.
Suggested change
| To pass through environment variables through to the Docker container that powers this action, you must prefix the environment variable with `RENOVATE_`. | |
| If you wish to pass environment variables to the Docker container that powers this action, prefix the environment variable with `RENOVATE_`. |
Is this what you want?
There was a problem hiding this comment.
no, remove the prefix suggestion completely. I know it's going worse for now but I don't like to suggest a totally wrong configuration.
we can leave the sample for now, or maybe better also remove it. I'll probably doing some changes when I'm back at work.
There was a problem hiding this comment.
I'll let you push the changes to my branch then! 😉
There was a problem hiding this comment.
then it has to wait until next week. ⛱️🍹
This comment was marked as resolved.
This comment was marked as resolved.
|
@viceice I resolved the merge conflict, I'll let you push the changes you want to my branch. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Context:
Adds info I asked about in:
Please review thoroughly for technical correctness!