Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation for docker-cmd-file #822

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

lazytesting
Copy link

related to #817

  • Validates if docker-cmd-file exists, is readable and has execute permission.
  • Made readme a bit more explicit regarding execute rights

src/renovate.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title Add validation for docker-cmd-file feat: Add validation for docker-cmd-file Feb 10, 2024
@viceice viceice mentioned this pull request Feb 12, 2024
src/renovate.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
src/renovate.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've updated a little, so you only need to do the async implementation

@lazytesting
Copy link
Author

i've updated a little, so you only need to do the async implementation

thanks for that, I added the async implementation

Comment on lines +129 to +130
(s.mode & fs.constants.R_OK) === 0 ||
(s.mode & fs.constants.X_OK) === 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(s.mode & fs.constants.R_OK) === 0 ||
(s.mode & fs.constants.X_OK) === 0
(s.mode & (fs.constants.R_OK | fs.constants.X_OK)) === 0

isn't this simpler?

@viceice
Copy link
Member

viceice commented Feb 21, 2024

i've updated a little, so you only need to do the async implementation

thanks for that, I added the async implementation

please use the re-request review button on PR to get another review

@viceice viceice marked this pull request as draft June 5, 2024 08:43
@viceice
Copy link
Member

viceice commented Jun 5, 2024

Marked as draft due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants