Several small changes, resolves #20 and resolves #21 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other types are just swallowed without any feedback of error
|
I am not able to see the semaphoreci build results, get I 404 despite a present account... |
|
The tests are green on my machine... |
so we can cleanup(close channel)
This reverts commit 45d7043.
so the message does not get deleted after one week todo: make the message ttl configurable
so the message does not get deleted after one week todo: make the message ttl configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys.
Thanks for your great lib. Use it a lot last time.
I would like you to merge this pull request. Sorry for not making several smaller pull requests.
My initial intention was to allow to specify the type of exchanges generated by ex-tackle(resolves #20, we need topic exchanges instead of direct exchanges).
Then I realized, that I cannot run tests twice because of already generated queues and exchanges, created during the previous test run. So I've adjusted many tests, so they clean up RabbitMQ after the test.
Since we use elixir formatter, many files have been changed by the formatter.
The last change I did to make almost all log output to log with debug level instead of info, so you get fewer messages. Then I've made the log output of RabbitMQ URL anonymous so that we do not leak the credentials anymore (resolves #21). For the test environment, I've changed the log target to be a file, because I was not able to silence all the error output produced by errors when consumers died in the tests and still use the stdout as log target.
All the changes I've made are backward compatible and we are using the changed ex-tackle in production for a few weeks already.
Thank you, guys.
Andreas