Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with clientLoader.hydrate when hydrating with bubbled errors #10063

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 4, 2024

Stacked on #9980

Remix half of remix-run/react-router#12070. Originally reported in discord via https://github.com/rossipedia/hydrate-error-shenanigans

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 9b413bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 changed the title Fig bug withclientLoader.hydrate when hydrating with bubbled errors Fig bug with clientLoader.hydrate when hydrating with bubbled errors Oct 7, 2024
@brophdawg11 brophdawg11 changed the title Fig bug with clientLoader.hydrate when hydrating with bubbled errors Fix bug with clientLoader.hydrate when hydrating with bubbled errors Oct 7, 2024
@brophdawg11 brophdawg11 force-pushed the brophdawg11/client-loader-hydrate-with-errors branch from 5dac626 to 3abd419 Compare October 9, 2024 15:56
@brophdawg11 brophdawg11 changed the base branch from dev to brophdawg11/stabilize-apis October 9, 2024 15:56
@brophdawg11 brophdawg11 force-pushed the brophdawg11/client-loader-hydrate-with-errors branch from 3abd419 to 0e87f65 Compare October 9, 2024 16:23
Base automatically changed from brophdawg11/stabilize-apis to dev October 9, 2024 17:11
@brophdawg11 brophdawg11 force-pushed the brophdawg11/client-loader-hydrate-with-errors branch from 0e87f65 to 9b413bc Compare October 9, 2024 17:12
@brophdawg11 brophdawg11 merged commit 43d08f9 into dev Oct 9, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/client-loader-hydrate-with-errors branch October 9, 2024 17:27
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🤖 Hello there,

We just published version 2.13.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.13.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant