Avoid vercel preset locally to prevent incorrect server index path #148
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather run locally the same code as in production as much as possible, that's why I took a different approach in my PR, by trying to find the server output file: Or have you found other issues with vercel builds running locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR ensures the
vercelPresetis only applied when building on Vercel. Applying it unconditionally was causing issues with the local build because the preset modifies the server index path.Specifically, it didn’t align with the local start command:
By conditionally including the preset only when
process.env.VERCELis set, we preserve correct behavior both locally and in the Vercel deployment environment.