Support URL instance as to
parameter.
#963
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue to be addressed
push
,replace
, andcreatePath
methods acceptto
parameter which isstring
orPartial<Path>
. ThePath
seems to be a partial to the nativeURL
which also containspathname: string, search: string, hash: string
.Also, given the library is used to work with URLs it's tempting to provide the actual
URL
instances. I often useURL
, and its.searchParams
to construct, change and manipulate URLs.Currently,
createURL
works fine if given anURL
instance, howeverpush
andreplace
takesnew URL('/foo?bar=biz', 'http://my.base/path')
as{}
.What's changed
This PR makes
getNextLocation
normalize givento
to be always a plain object.(Plus, it makes
getNextLocation
a bit DRYier)Possible improvements
If this library aims to support environments without
URL
, we could addtypeof URL === 'function'
, then assume the givento
object is just aPath
literal.