Fix emp run lockup in 0.13 #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.13, stdout/stderr were split using the stdcopy package. Unfortunately, this doesn't play well with streamhttp.Heartbeat, which sends null characters and causes the emp client to lockup. This removes the heartbeat, since it's mostly unecessary, and causes other weird side effects (e.g. if you're using tmux, the pain will get "active" because it thinks there's output). If using an ELB in front of the Empire daemon, the best thing to do is set a high idle timeout (maximum is 60 minutes) to prevent emp run sessions with no output from being killed. This is already the default recommendation in docs/cloudformation.json.
bmarini
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113
In 0.13, stdout/stderr for
emp runwas split using the stdcopy package. Unfortunately, this doesn't play well with streamhttp.Heartbeat, which sends null characters and causes the emp client to lockup.This removes the heartbeat, since it's mostly unnecessary, and causes other weird side effects (e.g. if you're using tmux, the pane will get "active" because it thinks there's output).
If using an ELB in front of the Empire daemon, the best thing to do is set a high idle timeout (maximum is 60 minutes) to prevent emp run sessions with no output from being killed. This is already the default recommendation in docs/cloudformation.json.