fix getUserData for apps that aren't bots#57
Conversation
gossi
force-pushed
the
fix-get-user-data-for-apps
branch
from
1b75595 to
b0c935d
Compare
gossi
changed the title
getUseData for apps that aren't botsgetUserData for apps that aren't bots
| let path = "users"; | ||
|
|
||
| // github API itself does not tell if contributor is an app. Best guess was to | ||
| // check the `html_url` for the `/apps/` segment |
There was a problem hiding this comment.
Can we not use type which is set to Bot for Copilot?
There was a problem hiding this comment.
Ah, I see, apps are a sub-type of Bot.
There was a problem hiding this comment.
Yeah, I'm not really sure that Github knows what it is doing. That seems very much like an impl without spec: "we need it, make it happen, doesn't matter how".
|
We also need to fix the name in the Committers list. This PR only changes it in the changes list. |
|
@wagenet which committers list? I think I touched all occurences I could find |
|
See the list at the end. However, this was generated from a patch based on this PR so maybe I missed something on my end. 
|
|
This should be handled. Tests do cover that case. Though |
4 participants
Fixes #56 - and in turn fixes a broken
release-plan